JIT: Add support for SwiftIndirectResult in Swift calling convention
#103570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 974f37a.
|
cc @dotnet/jit-contrib PTAL @amanasifkhalid |
amanasifkhalid
approved these changes
Jun 17, 2024
| @@ -2118,7 +2137,7 @@ void Compiler::impPopArgsForSwiftCall(GenTreeCall* call, CORINFO_SIG_INFO* sig, | |||
|
|
|||
| // If using SwiftError*, spill entire stack as we will need to reuse the | |||
| // error argument after the call. | |||
| if (checkEntireStack) | |||
| if (spillStack) | |||
There was a problem hiding this comment.
Could you update this comment to mention the SwiftIndirectResult case, please?
There was a problem hiding this comment.
I moved the existing comment up to where we assign spillStack in the SwiftError* case instead (there is already a comment on the new spillStack = true I added)
This was referenced Jun 18, 2024
Open
42 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a test for pinvoke/reverse pinvokes involving
SwiftIndirectResult, and add the necessary support to make the tests pass in RyuJIT.