Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arm64/SVE: Implemented RoundAwayFromZero, RoundToNearest, RouteToNegativeInfininty, RoundToPositiveInfinity, RoundToZero #103588

Merged
merged 17 commits into from
Jun 18, 2024
Merged

Arm64/SVE: Implemented RoundAwayFromZero, RoundToNearest, RouteToNegativeInfininty, RoundToPositiveInfinity, RoundToZero #103588

merged 17 commits into from
Jun 18, 2024

Conversation

ebepho
Copy link
Contributor

@ebepho ebepho commented Jun 17, 2024 •
edited
Loading

Contributes to #99957

Stress test output:

Passed test: _Sve_r::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_RoundAwayFromZero_float() : 16
Passed test: _Sve_r::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_RoundAwayFromZero_double() : 16
Passed test: _Sve_r::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_RoundToNearest_float() : 16
Passed test: _Sve_r::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_RoundToNearest_double() : 16
Passed test: _Sve_r::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_RoundToNegativeInfinity_float() : 16
Passed test: _Sve_r::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_RoundToNegativeInfinity_double() : 16
Passed test: _Sve_r::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_RoundToPositiveInfinity_float() : 16
Passed test: _Sve_r::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_RoundToPositiveInfinity_double() : 16
Passed test: _Sve_r::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_RoundToZero_float() : 16
Passed test: _Sve_r::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_RoundToZero_double() : 16
===================Running jitstress===================
------------------- {'JitMinOpts': '1'} -------------------
------------------- {'JitStress': '1'} -------------------
------------------- {'JitStress': '2'} -------------------
------------------- {'JitStress': '1', 'TieredCompilation': '1'} -------------------
------------------- {'JitStress': '2', 'TieredCompilation': '1'} -------------------
------------------- {'TailcallStress': '1'} -------------------
------------------- {'ReadyToRun': '0'} -------------------
===================Running jitstressregs===================
------------------- {'JitStressRegs': '1'} -------------------
------------------- {'JitStressRegs': '2'} -------------------
------------------- {'JitStressRegs': '3'} -------------------
------------------- {'JitStressRegs': '4'} -------------------
------------------- {'JitStressRegs': '8'} -------------------
------------------- {'JitStressRegs': '0x10'} -------------------
------------------- {'JitStressRegs': '0x80'} -------------------
------------------- {'JitStressRegs': '0x1000'} -------------------
------------------- {'JitStressRegs': '0x2000'} -------------------
===================Running jitstress2-jitstressregs===================
------------------- {'JitStress': '2', 'JitStressRegs': '1'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '2'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '3'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '4'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '8'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '0x10'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '0x80'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '0x1000'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '0x2000'} -------------------


Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_RoundAwayFromZero_float() : 16
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_RoundAwayFromZero_double() : 16
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_RoundToNearest_float() : 16
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_RoundToNearest_double() : 16
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_RoundToNegativeInfinity_float() : 16
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_RoundToNegativeInfinity_double() : 16
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_RoundToPositiveInfinity_float() : 16
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_RoundToPositiveInfinity_double() : 16
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_RoundToZero_float() : 16
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_RoundToZero_double() : 16
===================Running jitstress===================
------------------- {'JitMinOpts': '1'} -------------------
------------------- {'JitStress': '1'} -------------------
------------------- {'JitStress': '2'} -------------------
------------------- {'JitStress': '1', 'TieredCompilation': '1'} -------------------
------------------- {'JitStress': '2', 'TieredCompilation': '1'} -------------------
------------------- {'TailcallStress': '1'} -------------------
------------------- {'ReadyToRun': '0'} -------------------
===================Running jitstressregs===================
------------------- {'JitStressRegs': '1'} -------------------
------------------- {'JitStressRegs': '2'} -------------------
------------------- {'JitStressRegs': '3'} -------------------
------------------- {'JitStressRegs': '4'} -------------------
------------------- {'JitStressRegs': '8'} -------------------
------------------- {'JitStressRegs': '0x10'} -------------------
------------------- {'JitStressRegs': '0x80'} -------------------
------------------- {'JitStressRegs': '0x1000'} -------------------
------------------- {'JitStressRegs': '0x2000'} -------------------
===================Running jitstress2-jitstressregs===================
------------------- {'JitStress': '2', 'JitStressRegs': '1'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '2'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '3'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '4'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '8'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '0x10'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '0x80'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '0x1000'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '0x2000'} -------------------

cc @dotnet/arm64-contrib

ebepho and others added 17 commits June 5, 2024 14:30
@ebepho
Added ConverToInt32 and ConvertToUInt32 for float inputs.
c738b77
@ebepho
Added flags to handle only low predicate registers.
35d39d9
@ebepho
Fixed merge conflicts.
7a781e1
@ebepho
Fix whitespace
1378d60
@ebepho
Remove special codegen flag
10c7a15
@ebepho
Added new test template for operations with different return types.
8004868
@ebepho
Merge branch 'main' into ConvertToInt32
af7ccd4 
updating branch due to assert issue.
@ebepho
Add new test template.
8cb76da
@ebepho
Added api for ConvertToInt32 and ConvertToUInt 32 for double.
abe25fc
@ebepho
fix merge conflicts.
0f51f38
@ebepho
Merge branch 'dotnet:main' into main
7fabb91
@ebepho
Merge branch 'main' of github.com:ebepho/runtime
d5374ca
@ebepho
Merge branch 'main' of github.com:ebepho/runtime
4aa224d
@ebepho
Round SVE intrinsics for floats.
49a6c85
@ebepho
Completed Round SVE fp apis.
bd2702d
@ebepho
Merge branch 'main' of github.com:ebepho/runtime
56601b4
@ebepho
Merge branch 'main' into round
6ba83c3
@dotnet-issue-labeler dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@dotnet-issue-labeler dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-runtime-intrinsics
See info in area-owners.md if you want to be subscribed.

@ebepho ebepho changed the title Round Arm64/SVE: Implement RoundAwayFromZero, RoundToNearest, RouteToNegativeInfininty, RoundToPositiveInfinity, RoundToZero Jun 17, 2024
@ebepho ebepho added the arm-sve Work related to arm64 SVE/SVE2 support label Jun 17, 2024
@ebepho ebepho changed the title Arm64/SVE: Implement RoundAwayFromZero, RoundToNearest, RouteToNegativeInfininty, RoundToPositiveInfinity, RoundToZero Arm64/SVE: Implemented RoundAwayFromZero, RoundToNearest, RouteToNegativeInfininty, RoundToPositiveInfinity, RoundToZero Jun 17, 2024
@kunalspathak kunalspathak mentioned this pull request Jun 17, 2024
Closed
kunalspathak
kunalspathak approved these changes Jun 17, 2024
View reviewed changes
Copy link
Member

@kunalspathak kunalspathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@build-analysis build-analysis bot mentioned this pull request Jun 17, 2024
Open
3 tasks
This was referenced Jun 17, 2024
Open
Closed
@ebepho ebepho closed this Jun 17, 2024
@amanasifkhalid
Copy link
Member

@ebepho did you mean to merge this?

@ebepho ebepho reopened this Jun 17, 2024
@ebepho
Copy link
Contributor Author

ebepho commented Jun 17, 2024

@ebepho did you mean to merge this?

Just wanted to double check that I had ran the tests for Sve_ro before anyone merges it. I'm ready to merge now.

This was referenced Jun 18, 2024
Open
Open
Open
@amanasifkhalid
Copy link
Member

/ba-g Known error #103642 now fixed

@ebepho ebepho merged commit b93061a into dotnet:main Jun 18, 2024
162 of 167 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kunalspathak kunalspathak kunalspathak approved these changes

Assignees

@ebepho ebepho

Labels
area-System.Runtime.Intrinsics arm-sve Work related to arm64 SVE/SVE2 support new-api-needs-documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ebepho @amanasifkhalid @kunalspathak