Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use allows ref struct in comparer interfaces #103604

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

stephentoub
Copy link
Member

Fixes #103270
Fixes #103323

Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-collections
See info in area-owners.md if you want to be subscribed.

@stephentoub
Copy link
Member Author

We didn't get to this in API review today. I'm going to go ahead and merge to get it in for P6, and we can back it out if we decide we don't want these (there's no naming discussion here, it's just a "do we or don't we").

@stephentoub
Copy link
Member Author

/ba-g failure is a mono build failure due to file not found

@stephentoub stephentoub merged commit eb14da9 into dotnet:main Jun 19, 2024
143 of 146 checks passed
@stephentoub stephentoub deleted the moreallowsrefstruct branch June 19, 2024 00:01
@github-actions github-actions bot locked and limited conversation to collaborators Jul 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants