Find all generic interface impls #103661
Closed
Find all generic interface impls #103661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rename InterfaceImplementor to RuntimeInterfaceImplementation - Use 'interface implementation chains' everywhere rather than a single interface implementation
When the base type has an interface and an unmarked derived type overrides a method on that interface, we would mark the overriding method without checking if the type is even marked. We will check if the declaring type is marked before marking the override.
- Make methods local methods with captured variables - Inline local variables - Only store interfaces in runtime interfaces dictionary if the type implements 1 or more interfaces - Rename variables
This reverts commit bb308c7.
dotnet-issue-labeler
bot
added
the
area-Tools-ILLink
|
Tagging subscribers to this area: @agocke, @sbomer, @vitek-karas |
This was referenced Jun 19, 2024
Open
|
Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up for #103317. Will update when that one is merged.