Add System.IO.Hashing dependency to windowsdesktop transport pack

[ViktorHofer]

System.IO.Hashing is a dependency of System.Formats.Nrbf.

Didn't realize that until just now. Continuation of 91f1481

[dotnet-policy-service]

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

[MichalStrehovsky]

I'd consider bypassing the CI and just slamming it in and canceling whatever official build is in progress so that we can finish the flow today. Official build is going to be 4 hours.

[ViktorHofer]

/ba-g this is a safe change (I double checked it) and we need this flowing asap for P6.

[ViktorHofer]

PR and official builds taking 4 hours is just crazy, isn't it? We should bring this up and invest in reducing this to at least half.

[MichalStrehovsky]

PR and official builds taking 4 hours is just crazy, isn't it? We should bring this up and invest in reducing this to at least half.

Yep. I canceled the official one that was in progress. It was only 20 minutes in, so it would take solid 8 hours to get a good build of dotnet/runtime out. Now we should have one in 4.

[am11]

Maybe official build should use a better pool with 32-64 cores machines? Linux distros builders, e.g., use those kind of beefy machines for official builds. Stands to reason company which owns Azure cloud can handle a pool of dozen such machines for .NET. 😉

[ViktorHofer]

Agree on that. But the other angle is that we can build runtime so much faster than what the official build does today. In the current version of the VMR (without join steps) runtime builds in less than 30 minutes. I expect that this time will go up when we add join point legs and signing but the entire VMR will still be faster than the current runtime official build.

[MichalStrehovsky]

https://dnceng.visualstudio.com/internal/_build/results?buildId=2477368&view=results

The PGO legs died on nuget restore issues. Anyone know if there's a way to rerun it while the build is still in progress? Or wait until it fails and then click rerun on the button that magically appears? Or just scrap the whole run?

[stephentoub]

System.IO.Hashing is a dependency of System.Formats.Nrbf.

Does it need to be? @adamsitnik, I see System.IO.Hashing being used in one place:

    public override int GetHashCode()
    {
        int id = _id;
#if NET
        Span<int> integers = new(ref id);
#else
        Span<int> integers = stackalloc int[1] { id };
#endif
        return (int)XxHash32.HashToUInt32(MemoryMarshal.AsBytes(integers));
    }

Why does this need to use XxHash32 rather than just being:

    public override int GetHashCode() => _id;

?