Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update HWIntrinsicInfo::lookupId to use a binary search #103778

Merged
merged 9 commits into from
Jun 24, 2024

Conversation

tannergooding
Copy link
Member

No description provided.

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jun 20, 2024
Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@tannergooding tannergooding force-pushed the hwintrin-binarylookup branch 2 times, most recently from 154a553 to 9319a0e Compare June 20, 2024 21:05
@tannergooding tannergooding force-pushed the hwintrin-binarylookup branch from 9319a0e to 08d03ef Compare June 20, 2024 21:55
@tannergooding tannergooding marked this pull request as ready for review June 21, 2024 21:32
@jkotas
Copy link
Member

jkotas commented Jun 22, 2024

What is the experience if somebody adds a new intrinsic and gets the order wrong?

@tannergooding
Copy link
Member Author

What is the experience if somebody adds a new intrinsic and gets the order wrong?

It depends on how they get it wrong. Assertions exist for some, but not all scenarios at the moment. In the worst case they'll only see SPMI regressions and test failures stemming from intrinsics no longer being resolved.

More ideally we'd have a simple one time validation path. I don't think we have an existing spot to easily do such validation today, so I can probably just have do it in lookupId, tracking if its already been done or not (debug only, of course).

@jkotas
Copy link
Member

jkotas commented Jun 22, 2024

I can probably just have do it in lookupId, tracking if its already been done or not (debug only, of course).

Yes, I think it would be a good idea.

@tannergooding
Copy link
Member Author

CC. @dotnet/jit-contrib, this should be ready for review.

src/coreclr/jit/hwintrinsic.cpp Outdated Show resolved Hide resolved
src/coreclr/jit/hwintrinsic.cpp Outdated Show resolved Hide resolved
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
@tannergooding tannergooding merged commit 7df87e8 into dotnet:main Jun 24, 2024
114 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants