-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update HWIntrinsicInfo::lookupId to use a binary search #103778
Update HWIntrinsicInfo::lookupId to use a binary search #103778
Conversation
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
154a553
to
9319a0e
Compare
9319a0e
to
08d03ef
Compare
What is the experience if somebody adds a new intrinsic and gets the order wrong? |
It depends on how they get it wrong. Assertions exist for some, but not all scenarios at the moment. In the worst case they'll only see SPMI regressions and test failures stemming from intrinsics no longer being resolved. More ideally we'd have a simple one time validation path. I don't think we have an existing spot to easily do such validation today, so I can probably just have do it in |
Yes, I think it would be a good idea. |
CC. @dotnet/jit-contrib, this should be ready for review. |
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
No description provided.