Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Http3 tests for Arm #103793

Merged
merged 1 commit into from
Jun 21, 2024
Merged

Conversation

liveans
Copy link
Member

@liveans liveans commented Jun 21, 2024

Related to #103703 and #103404

Copy link
Contributor

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

@jkotas
Copy link
Member

jkotas commented Jun 21, 2024

FWIW, these tests are not crashing frequently enough to require disabling all Quic testing on Arm. The crashes should be picked up by the know issue pattern match. I just updated it to be specific to arm.

(If you prefer disabling the test, you can certainly do that.)

@liveans
Copy link
Member Author

liveans commented Jun 21, 2024

FWIW, these tests are not crashing frequently enough to require disabling all Quic testing on Arm. The crashes should be picked up by the know issue pattern match. I just updated it to be specific to arm.

(If you prefer disabling the test, you can certainly do that.)

We think that this problem can be solved with msquic v2.4 release, also I agree that this can actually stay without disabling it, given that only affected CI is runtime-extra-platforms, and since it will be picked up by known issues, we should be fine.

@dotnet/ncl any pushback?

@rzikm
Copy link
Member

rzikm commented Jun 21, 2024

given that only affected CI is runtime-extra-platforms

The issue affects the outerloop pipeline as well

image

Given that we already disable Quic tests on ARM32, doing the same for HTTP3 tests still makes sense to me.

@liveans
Copy link
Member Author

liveans commented Jun 21, 2024

/ba-g test failures are unrelated

@liveans liveans merged commit 8923c96 into dotnet:main Jun 21, 2024
79 of 83 checks passed
rzikm pushed a commit to rzikm/dotnet-runtime that referenced this pull request Jun 24, 2024
@karelz karelz added this to the 9.0.0 milestone Jun 24, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jul 25, 2024
@antonfirsov antonfirsov added the disabled-test The test is disabled in source code against the issue label Dec 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Net.Http disabled-test The test is disabled in source code against the issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants