Fix assertion/possible deadlock in thread shutdown in the presence of ThreadStatics on collectible assemblies #104003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… ThreadStatics on collectible assemblies
|
Tagging subscribers to this area: @mangod9 |
Open
3 tasks
mangod9
approved these changes
Jun 26, 2024
src/coreclr/vm/object.h
Outdated
| @@ -2099,6 +2100,7 @@ class LoaderAllocatorObject : public Object | |||
| return m_slotsUsed; | |||
| } | |||
|
|
|||
| // All uses of this must be protected by m_crstLoaderAllocatorHandleTable | |||
| void SetSlotsUsed(INT32 newSlotsUsed) | |||
There was a problem hiding this comment.
Same comment as GetHandleTable?
…e the LoaderAllocator handle table
Co-authored-by: Aaron Robinson <arobins@microsoft.com>
3 tasks
…avidwrighton/runtime into fix_thread_statics_collectible
This was referenced Jun 27, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move all the locked accesses of the handle table and free list to being under a leaf lock