-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add QEMU detection check #104125
Add QEMU detection check #104125
Conversation
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries |
@tomeksowi @yurai007 Does this detect the QEMU RISCV environment that you are using to run tests? |
f0eacc3
to
3a7fa93
Compare
src/libraries/Common/src/Interop/Unix/System.Native/Interop.IsQemuDetected.cs
Outdated
Show resolved
Hide resolved
4a13734
to
e4030bf
Compare
e4030bf
to
98484de
Compare
GC scenario test failure seems to be #63774, unrelated to changes. |
@jkotas: let me check this, I will share results soon. |
Given that this is not a reliable method to detect QEMU, I do not think that it is a good fit for minipal and production code. |
@jkotas did you try it? |
I did not. I can believe what @yurai007 says. I do not particularly like that the change has 3 different ways to guess whether the process is running under QEMU. It suggests that it is not reliable. I wish there was one proper way to detect QEMU that is documented on https://qemu.org/. |
https://github.com/dotnet/runtime/pull/104094/files#r1657541084