[wasm] Disallow not useful configuration combinations #104149
Conversation
ilonatommy
requested review from
maraf,
akoeplinger,
lewing and
pavelsavara
as code owners
src/mono/sample/wasm/browser-profile/Wasm.BrowserProfile.Sample.csproj
Outdated
Show resolved
Hide resolved
|
Does AOT + application in Debug have better stack traces than AOT + application in Release ? (runtime being always in Release) |
I was assuming it should be better in debug but I tested experimentally, sample app throwing an exception from C# and stack traces do not differ. Do you have a better idea how to check it? |
|
I would expect Debug to have source code line numbers in the C# stack trace. |
I understand. Sadly, no line numbers, dwarf present |
| @@ -621,6 +621,8 @@ | |||
|
|
|||
| <Error Condition="'$(RunAOTCompilation)' == 'true' and '$(PublishTrimmed)' != 'true'" | |||
| Text="AOT is not supported without IL trimming (PublishTrimmed=true required)." /> | |||
| <Error Condition="'$(RunAOTCompilation)' == 'true' and '$(Configuration)' == 'Debug'" | |||
There was a problem hiding this comment.
What is the true underlaying requirement for AOT? The configuration name "Debug" is just a name, user can have a custom name.
There was a problem hiding this comment.
We rely on Configuration variable value, comparing it with Release and Debug in multiple places.
Line 495 in 27d1ab0
Do you mean that there's a better property to check if we have debug symbols available?
There was a problem hiding this comment.
I'm aware of other places (that they exist) and every now and then they fail for some user with custom config name (there not much of them, but such users exist). So I would like to know if there is a better property to check and hence the question what is the true underlaying requirement for AOT compiler, so we could check that requirement instead.
If the requirement is one of the places where we check for config==debug, there is nothing to do about it. If the requirement is something different with some concrete property value, it would be great to check that property.
There was a problem hiding this comment.
I see. The requirement: runtime without optimization (so debug-friendly) will take long time to build app with AOT and in the end it won't support managed debugging, so there was no point. Useful properties would be connected with managed debugging or optimization on/off (looking for such...).
There was a problem hiding this comment.
I am not able to find a good alternative
Fixes #94103.
Switches off possibility of using
RunAOTCompilationin debug mode - aot doesn't support managed debugging, so this combination does not make sense. Corresponding WBT that were testing this combination are removed. A special test for WASM and for Blazor is added to make sure the combination produces a proper error.One fix in the JS code was needed to fix running profiler sample on browser. Beyond it, profiled aot works fine with and without
PublishTrimmedin debug mode, it does not have to be blocked.