Add support for AES-GCM and ChaCha20Poly1305 on iOS/tvOS/MacCatalyst via CryptoKit #104383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…via CryptoKit Now that we support minimum OS versions that ship with Swift we can enable CryptoKit and pal_swiftbindings.swift. Fixes dotnet#91523
akoeplinger
requested review from
vcsjones,
jkoritzinsky,
filipnavara and
bartonjs
|
Note regarding the |
1 similar comment
|
Note regarding the |
akoeplinger
commented
Jul 3, 2024
Comment on lines
+49
to
+53
| if (CMAKE_BUILD_TYPE STREQUAL "Debug") | ||
| set(SWIFT_OPTIMIZATION_FLAG "-Onone") | ||
| elseif (CMAKE_BUILD_TYPE STREQUAL "Release") | ||
| set(SWIFT_OPTIMIZATION_FLAG "-O") | ||
| endif() |
There was a problem hiding this comment.
I noticed that we didn't compile the swift code with optimizations so fixed this as well
vcsjones
reviewed
Jul 3, 2024
...n/tests/System/Security/Cryptography/AlgorithmImplementations/ECDsa/ECDsaTests.netcoreapp.cs
Show resolved
Hide resolved
src/native/libs/System.Security.Cryptography.Native.Apple/extra_libs.cmake
Outdated
Show resolved
Hide resolved
bartonjs
reviewed
Jul 3, 2024
src/libraries/System.Security.Cryptography/ref/System.Security.Cryptography.cs
Show resolved
Hide resolved
bartonjs
reviewed
Jul 3, 2024
src/libraries/System.Security.Cryptography/tests/AesGcmTests.cs
Outdated
Show resolved
Hide resolved
bartonjs
reviewed
Jul 3, 2024
src/native/libs/System.Security.Cryptography.Native.Apple/CMakeLists.txt
Outdated
Show resolved
Hide resolved
|
For NativeAOT failures, the "osx" restriction should be changed to here and here |
Interesting, I explicitly checked this locally and it worked without that change for me. |
|
@akoeplinger oh and probably |
vcsjones
reviewed
Jul 22, 2024
| @@ -203,7 +196,7 @@ public static void TwoEncryptionsAndDecryptionsUsingOneInstance() | |||
| byte[] nonce2 = "8ba10892e8b87d031196bf99".HexToByteArray(); | |||
|
|
|||
| byte[] expectedCiphertext1 = "f1af1fb2d4485cc536d618475d52ff".HexToByteArray(); | |||
| byte[] expectedTag1 = PlatformDetection.IsOSX ? | |||
| byte[] expectedTag1 = (PlatformDetection.IsOSX || PlatformDetection.UsesMobileAppleCrypto) ? | |||
There was a problem hiding this comment.
Not blocking but we could simplify this to PlatformDetection.IsApplePlatform
|
/ba-g the one unknown test failure is happening on wasm so can't be related to the changes in this PR. |
This was referenced Jul 22, 2024
vcsjones
added
the
cryptographic-docs-impact
bartonjs
added
the
tracking
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we support minimum OS versions that ship with Swift we can enable CryptoKit and pal_swiftbindings.swift.
Fixes #91523
Fixes #52482