Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mono] Support copying arrays of compatible pointers #104611

Merged
merged 10 commits into from
Jul 10, 2024
Merged

[mono] Support copying arrays of compatible pointers #104611

merged 10 commits into from
Jul 10, 2024

Conversation

steveisok
Copy link
Member

Fixes #104197

@steveisok steveisok requested review from fanyang-mono and kg July 9, 2024 15:15
@build-analysis build-analysis bot mentioned this pull request Jul 9, 2024
Open
3 tasks
lambdageek
lambdageek reviewed Jul 9, 2024
View reviewed changes
Copy link
Member

@lambdageek lambdageek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly ok, but I don't think the change to is_subclass_of is justified

src/mono/mono/metadata/class.c Outdated Show resolved Hide resolved
This was referenced Jul 10, 2024
Open
Open
Open
Closed
Open
Closed
Closed
Open
Closed
@build-analysis build-analysis bot mentioned this pull request Jul 10, 2024
Closed
@steveisok steveisok merged commit 5b70af8 into dotnet:main Jul 10, 2024
111 of 117 checks passed
@steveisok steveisok deleted the fix-compat-ptrs branch July 10, 2024 17:22
matouskozak added a commit to matouskozak/runtime that referenced this pull request Jul 11, 2024
@matouskozak
Revert "[mono] Support copying arrays of compatible pointers (dotnet#…
e343d83 
…104611)"

This reverts commit 5b70af8.
@github-actions github-actions bot locked and limited conversation to collaborators Aug 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fanyang-mono fanyang-mono fanyang-mono approved these changes

@lambdageek lambdageek lambdageek approved these changes

@thaystg thaystg Awaiting requested review from thaystg thaystg is a code owner

@marek-safar marek-safar Awaiting requested review from marek-safar

@kg kg Awaiting requested review from kg

Assignees

@steveisok steveisok

Labels
area-VM-meta-mono
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[mono] Support copying arrays of compatible pointers
3 participants
@steveisok @lambdageek @fanyang-mono