Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Ubuntu 18 images with Ubuntu 20 in ARM 64 runs #104689

Conversation

rzikm
Copy link
Member

@rzikm rzikm commented Jul 10, 2024

Closes #103354.

TLS resumption does not work reliably with the OpenSSL version present on Ubuntu 18.04 distribution. Since the distro in question is past EOL, we should simply update the queues to more recent distro image.

Copy link
Contributor

Tagging subscribers to this area: @dotnet/ncl, @bartonjs, @vcsjones
See info in area-owners.md if you want to be subscribed.

@wfurt
Copy link
Member

wfurt commented Jul 10, 2024

we should not be running on EOS system, right? If anything I feel we should update the run queue(s).

@rzikm
Copy link
Member Author

rzikm commented Jul 11, 2024

we should not be running on EOS system, right? If anything I feel we should update the run queue(s).

Right, I see 18.04 has already been replaced with newer OSes on other platforms, so I changed this PR to update the queues to 20.04 images instead.

@rzikm rzikm requested review from stephentoub, MihaZupan and wfurt July 11, 2024 08:45
@rzikm rzikm changed the title Disable (No)ClientCert_DefaultValue_ResumeSucceeds only on Ubuntu 18 ARM Replace Ubuntu 18 images with Ubuntu 20 in ARM 64 runs Jul 11, 2024
@rzikm
Copy link
Member Author

rzikm commented Jul 11, 2024

Test failures are related

    System.Net.Quic.Tests.MsQuicPlatformDetectionTests.SupportedLinuxPlatforms_IsSupportedIsTrue [FAIL]
      Assert.True() Failure
      Expected: True
      Actual:   False
      Stack Trace:
        /_/src/libraries/System.Net.Quic/tests/FunctionalTests/MsQuicPlatformDetectionTests.cs(69,0): at System.Net.Quic.Tests.MsQuicPlatformDetectionTests.SupportedLinuxPlatforms_IsSupportedIsTrue()
           at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
        /_/src/coreclr/System.Private.CoreLib/src/System/Reflection/MethodBaseInvoker.CoreCLR.cs(36,0): at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
        /_/src/libraries/System.Private.CoreLib/src/System/Reflection/MethodBaseInvoker.cs(57,0): at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)
      Output:
        Running on Distro=ubuntu VersionId=20.4
    System.Net.Quic.Tests.MsQuicPlatformDetectionTests.UnsupportedPlatforms_ThrowsPlatformNotSupportedException [PASS]
      Output:
        System.Net.Quic is not supported on this platform: Unable to load MsQuic library version '2'. For more information see: 

The image is missing MsQuic, we will need to update the image before merging this PR

edit, actually we might want to update to 22.04, since that image already contains MsQuic.

This reverts commit 0d42116.
@rzikm
Copy link
Member Author

rzikm commented Jul 12, 2024

/ba-g None of the failures are on the new platform or the test in question.

@rzikm rzikm merged commit 25f82f3 into dotnet:main Jul 12, 2024
116 of 123 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 12, 2024
@karelz karelz added this to the 9.0.0 milestone Sep 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

System.Net.Security.Tests.SslStreamTlsResumeTests failing
5 participants