JIT: Remove GTF_IS_IN_CSE
#104855
Merged
JIT: Remove GTF_IS_IN_CSE
#104855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This flag is just a convoluted way to pass an argument through to a bunch of methods from inside CSE. That's because CSE tries to reuse `gtExtractSideEffList` even though it needs something more capable that considers CSE defs and CSE uses as well. Remove the flag in favor of an `ignoreCctors` flag in the side effect checking functions; then, additionally add a CSE-specific version of `gtExtractSideEffList` called `optExtractSideEffectsForCSE` which handles side effects and also CSE defs/uses. This does result in a slight amount of duplication, but I think that's beneficial over the convoluted logic before.
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
jakobbotsch
commented
Jul 13, 2024
| @@ -17221,7 +17201,6 @@ void Compiler::gtExtractSideEffList(GenTree* expr, | |||
| } | |||
|
|
|||
| GenTree* comma = m_compiler->gtNewOperNode(GT_COMMA, TYP_VOID, m_result, node); | |||
| comma->gtFlags |= (m_result->gtFlags | node->gtFlags) & GTF_ALL_EFFECT; | |||
There was a problem hiding this comment.
gtNewOperNode does the flags propagation already.
|
cc @dotnet/jit-contrib PTAL @AndyAyersMS No diffs. Minor TP improvements. |
AndyAyersMS
approved these changes
Jul 15, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This flag is just a convoluted way to pass an argument through to a bunch of methods from inside CSE. That's because CSE tries to reuse
gtExtractSideEffListeven though it needs something more capable that considers CSE defs and CSE uses as well.Remove the flag in favor of an
ignoreCctorsflag in the side effect checking functions; then, additionally add a CSE-specific version ofgtExtractSideEffListcalledoptExtractSideEffectsForCSEwhich handles side effects and also CSE defs/uses. This does result in a slight amount of duplication, but I think that's beneficial over the convoluted logic before.No diffs are expected.