Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ActivityRecorder more threadsafe #104888

Merged
merged 1 commit into from
Jul 15, 2024
Merged

Make ActivityRecorder more threadsafe #104888

merged 1 commit into from
Jul 15, 2024

Conversation

rzikm
Copy link
Member

@rzikm rzikm commented Jul 15, 2024 •
edited
Loading

Fixes #104883.

Original issue appear because of race on Started++. This PR replaces those with Interlocked.Increment and adds a lock around _finishedActivities

cc @antonfirsov.

@rzikm rzikm requested a review from a team July 15, 2024 11:17
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/ncl, @bartonjs, @vcsjones
See info in area-owners.md if you want to be subscribed.

liveans
liveans approved these changes Jul 15, 2024
View reviewed changes
Copy link
Member

@liveans liveans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assuming that CI passes

@rzikm rzikm merged commit a20847d into dotnet:main Jul 15, 2024
83 checks passed
@rzikm rzikm deleted the 104883-`SystemNetSecurityTestsTelemetryTestSuccessfulHandshake_ActivityRecorded`-failures-in-CI branch July 15, 2024 13:13
@akoeplinger akoeplinger mentioned this pull request Jul 15, 2024
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Aug 15, 2024
@karelz karelz added this to the 9.0.0 milestone Sep 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@liveans liveans liveans approved these changes

Assignees

@rzikm rzikm

Labels
area-System.Net.Security
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.

System.Net.Security.Tests.TelemetryTest.SuccessfulHandshake_ActivityRecorded failures in CI
3 participants
@rzikm @liveans @karelz