-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Emit More EventSource Data For Metrics Measurements #104993
Emit More EventSource Data For Metrics Measurements #104993
Conversation
/azp run runtime-libraries-coreclr outerloop |
Azure Pipelines successfully started running 1 pipeline(s). |
src/libraries/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/Helpers.cs
Show resolved
Hide resolved
...ies/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/Metrics/MetricsEventSource.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/Helpers.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few suggestions inline
...ies/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/Metrics/MetricsEventSource.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/Metrics/Meter.cs
Outdated
Show resolved
Hide resolved
...ies/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/Metrics/MetricsEventSource.cs
Outdated
Show resolved
Hide resolved
@wiktork @jander-msft - heads up since dotnet-monitor probably wants to consume this data too. Unless we get some extension the checkin deadline is the end of the week so this is likely to go fast. |
...ies/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/Metrics/MetricsEventSource.cs
Outdated
Show resolved
Hide resolved
...ies/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/Metrics/MetricsEventSource.cs
Outdated
Show resolved
Hide resolved
c73dfed
to
ed34eae
Compare
…iagnostics/Helpers.cs Co-authored-by: Stephen Toub <stoub@microsoft.com>
ed34eae
to
95024ec
Compare
/azp run runtime-libraries-coreclr outerloop |
Azure Pipelines successfully started running 1 pipeline(s). |
@noahfalk I have updated the code according to our offline discussion with introducing the instrument Id in our emitted events. If you are interested in looking at the update, please look at the last commit. Thanks! |
LGTM! |
Fixes #93097 and #93767
This change enables the emission of additional metrics data during measurement publishing. Specifically, it will emit the instrument's formatted tags and hash, as well as the meter's formatted tags, scope hash, and meter hash. With this extra data, aggregators can easily differentiate between instruments created with identical parameters such as name, tags, and units. Similarly, it allows for distinguishing between meters created with the same parameters, such as meter name, version, tags, and scope.