Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit More EventSource Data For Metrics Measurements #104993

Merged

Conversation

tarekgh
Copy link
Member

@tarekgh tarekgh commented Jul 16, 2024

Fixes #93097 and #93767

This change enables the emission of additional metrics data during measurement publishing. Specifically, it will emit the instrument's formatted tags and hash, as well as the meter's formatted tags, scope hash, and meter hash. With this extra data, aggregators can easily differentiate between instruments created with identical parameters such as name, tags, and units. Similarly, it allows for distinguishing between meters created with the same parameters, such as meter name, version, tags, and scope.

@tarekgh
Copy link
Member Author

tarekgh commented Jul 16, 2024

/azp run runtime-libraries-coreclr outerloop

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@noahfalk noahfalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions inline

@noahfalk
Copy link
Member

@wiktork @jander-msft - heads up since dotnet-monitor probably wants to consume this data too. Unless we get some extension the checkin deadline is the end of the week so this is likely to go fast.

@tarekgh tarekgh force-pushed the EmitMoreEventSourceDataForMetricsMeasurments branch from ed34eae to 95024ec Compare July 21, 2024 02:06
@tarekgh
Copy link
Member Author

tarekgh commented Jul 21, 2024

/azp run runtime-libraries-coreclr outerloop

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@tarekgh
Copy link
Member Author

tarekgh commented Jul 21, 2024

@noahfalk I have updated the code according to our offline discussion with introducing the instrument Id in our emitted events. If you are interested in looking at the update, please look at the last commit. Thanks!

@tarekgh tarekgh merged commit 9e23387 into dotnet:main Jul 21, 2024
84 of 92 checks passed
@noahfalk
Copy link
Member

LGTM!

@tarekgh tarekgh deleted the EmitMoreEventSourceDataForMetricsMeasurments branch August 6, 2024 20:04
@github-actions github-actions bot locked and limited conversation to collaborators Sep 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MetricEventSource value published events don't resolve which scope they are refering to
4 participants