-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mono] Issue #103365 follow-up PR #105006
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
kg
commented
Jul 17, 2024
- Slightly reduce memory usage for classes without a variance search table (many of them)
- Make the variance search table for a given class larger, but remove the need to recursively search every table in the hierarchy
- Optimize out the additional interfaces list scan to compute the interface offset once we find a match in the variance table
This was referenced Jul 17, 2024
lambdageek
reviewed
Jul 17, 2024
lambdageek
reviewed
Jul 17, 2024
lambdageek
reviewed
Jul 17, 2024
lambdageek
reviewed
Jul 17, 2024
lambdageek
reviewed
Jul 17, 2024
lambdageek
reviewed
Jul 17, 2024
lambdageek
reviewed
Jul 17, 2024
lambdageek
reviewed
Jul 17, 2024
This was referenced Jul 19, 2024
Open
Address PR feedback More assertions
lambdageek
reviewed
Jul 19, 2024
This was referenced Jul 19, 2024
Closed
lambdageek
approved these changes
Jul 20, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.