Ensure that the handling for the V128_BITCAST APIs is correctly performant on Mono WASM #105009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rmant on Mono WASM
|
Tagging subscribers to this area: @BrzVlad, @kotlarmilos |
|
The MOV_VT numbers are very promising! Thanks for chasing this down. |
This was referenced Jul 17, 2024
tannergooding
requested review from
lewing,
pavelsavara,
BrzVlad and
kotlarmilos
as code owners
|
This should be ready for review, CI failures are flaky tests hitting OOM/timeouts and I'm rerunning them |
BrzVlad
approved these changes
Jul 17, 2024
|
@tannergooding thanks for getting this done so quickly, the initial data from our benchmarks also indicate there now a net improvement in here. Excellent work. |
|
@mkhamoyan can you please update the documentation in dotnet/performance |
|
Glad I was finally able to figure it out, hopefully it should make future improvements easier as well 😄 |
This was referenced Jul 20, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only gave a single example below, but did run a sampling of benchmarks and the results look to be correct now.
Notably the docs for running WASM benchmarks is very out of date right now: https://github.com/dotnet/performance/blob/main/docs/benchmarking-workflow-dotnet-runtime.md#dotnet-runtime-testing-for-wasm, I ended up getting it working but having up to date guidance would be great.
-- Most notably
test-main.jswas moved, tests won't run since it can't find the9.0.0-devpackages, andtest-main.jswas updated to require--moduleThis should resolve dotnet/perf-autofiling-issues#38466
Interpreter
No Handling
V128_BITCAST Handling
MOV_VT Handling
AOT
No Handling
V128_BITCAST Handling
MOV_VT Handling