Fix intellisense package xml file failing up-to-date check in libs projects #105243
Conversation
dotnet-issue-labeler
bot
added
the
needs-area-label
ViktorHofer
added
area-Infrastructure-libraries
and removed
needs-area-label
|
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries |
| <Target Name="PrepareIntellisensePackageXmlFile" | ||
| Inputs="$(IntellisensePackageXmlFilePath)" | ||
| Outputs="$(IntermediateDocFileItemFromIntellisensePackage)"> | ||
| <Copy SourceFiles="$(IntellisensePackageXmlFilePath)" |
There was a problem hiding this comment.
Wouldn't the copy be enough to give the new file a new creation timestamp? Why is the touch below needed?
There was a problem hiding this comment.
This is about modification date&time which doesn't get updated by the Copy task.
| BeforeTargets="CopyFilesToOutputDirectory;DocumentationProjectOutputGroup" | ||
| Condition="'$(UseCompilerGeneratedDocXmlFile)' != 'true' and '$(IntellisensePackageXmlFilePath)' != ''"> | ||
| <ItemGroup> | ||
| <DocFileItem Remove="@(DocFileItem)" /> | ||
| <DocFileItem Include="$(IntellisensePackageXmlFilePath)" /> | ||
| <DocFileItem Include="$(IntermediateDocFileItemFromIntellisensePackage)" /> |
There was a problem hiding this comment.
Do we need to revert the name to the original after this? I wonder if the new suffix *.intellisense-package* would affect our process. It was my understanding that the intellisense file needs to match the assembly name, except for the extension.
There was a problem hiding this comment.
This is just the name of the intermediate file in the obj directory. We need a different name as we also have the compiler generated xml file. The final output path is the expected one: AssemblyName.xml.
Fixes #92940
Tested locally and verified that the correct xml file lands in the intermediate and in the final output folder, with the correct time stamps. Also tested that this really fixes the broken fast up-to-date check.