[mono][interp] Remove short branches #105386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sets Previously they were all short branches without long counterparts. This was buggy and awkward because we tried to compute early conservatively whether a branch is short or long, at superins generation time. The conditions would always hold and we had no fallback if the branch didn't turn out to actually be short. Having a long offset for these branches should have negligible perf impact.
…pass We generate superins without caring if the branch is long or short since the superinstructions use a long offset now.
BrzVlad
requested review from
lewing,
pavelsavara and
kotlarmilos
as code owners
|
Tagging subscribers to this area: @BrzVlad, @kotlarmilos |
BrzVlad
force-pushed
the
fix-interp-short-branches
branch
from
057e2bd to
6a54c14
Compare
kg
approved these changes
Jul 24, 2024
BrzVlad
force-pushed
the
fix-interp-short-branches
branch
4 times, most recently
from
a519562 to
ea69694
Compare
They don't seem to have any benefit at the expense of a lot of code and added complexity.
BrzVlad
force-pushed
the
fix-interp-short-branches
branch
from
ea69694 to
17ed1c3
Compare
This was referenced Jul 31, 2024
|
@kg It wouldn't hurt to take another look at this, just in case by deleting some of the long short opcodes I'm accidentally breaking generation of some traces. The microbenchmarks should show something anyway if that is the case though. |
|
I'll take a look at the stats on browser-bench, and it should show up in microbenchmarks for sure. Thanks for pushing this across the finish line :) |
This was referenced Aug 7, 2024
BrzVlad
added a commit
to BrzVlad/runtime
that referenced
this pull request
Aug 9, 2024
This reverts commit ac89819.
BrzVlad
added a commit
that referenced
this pull request
Aug 9, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They don't really seem to have perf benefits, at the expense of quite a bit of implementation cost with existing issues that are awkward to fix.