Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up some usages of LowLevelList<T> #105407

Merged
merged 10 commits into from
Jul 26, 2024
Merged

Clean up some usages of LowLevelList<T> #105407

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
09db328
Replace LowLevelListWithIList<T> usage in reflection with List<T>
huoyaoyuan Jul 24, 2024
ebce330
Delete LowLevelListWithIList<T> type
huoyaoyuan Jul 24, 2024
83718e1
Remove never used members
huoyaoyuan Jul 24, 2024
4c80f0b
Replace CopyTo with ArrayBuilder
huoyaoyuan Jul 24, 2024
802a46b
Replace ToArray with ArrayBuilder
huoyaoyuan Jul 24, 2024
9242d5f
Fix inverted condition
huoyaoyuan Jul 24, 2024
b96af64
Fix CopyTo with covariant destination
huoyaoyuan Jul 24, 2024
25bb81b
Update semantic of AsSpan
huoyaoyuan Jul 25, 2024
7f5e07d
Replace more List usage with ArratBuilder
huoyaoyuan Jul 25, 2024
e58c5a9
Fix AsSpan
huoyaoyuan Jul 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/coreclr/tools/Common/System/Collections/Generic/ArrayBuilder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ public void Add(T item)
}

#if NET
public readonly Span<T> AsSpan(int start) => _items.AsSpan(start);
public readonly Span<T> AsSpan(int start) => _items.AsSpan(start, _count);
huoyaoyuan marked this conversation as resolved.
Show resolved Hide resolved

public Span<T> AppendSpan(int length)
{
Expand Down
Loading