[release/9.0-preview7] Fix platform analyzer attribute order for MacCatalyst

[github-actions]

Backport of #105409 to release/9.0-preview7

/cc @akoeplinger

Customer Impact

• Customer reported
• Found internally

We need to make sure the attribute for MacCatalyst comes after the iOS one due to how MacCatalyst is a superset of iOS: learn.microsoft.com/en-us/dotnet/standard/analyzers/platform-compat-analyzer#platform-inclusion

This caused an error in aspnetcore in the latest dependency flow because the analyzer thought AesGcm is only supported on MacCatalyst:

error CA1416: (NETCORE_ENGINEERING_TELEMETRY=Build) This call site is reachable on all platforms. 'AesGcm.Decrypt(ReadOnlySpan, ReadOnlySpan, ReadOnlySpan, Span, ReadOnlySpan)' is only supported on: 'maccatalyst' 13.0 and later.

Regression

• Yes
• No

The attributes were only added recently a couple days ago.

Testing

Tested locally by overwriting the ref assembly in my dotnet SDK and observing the analyzer warning to be fixed.

Risk

Low, this just reorders the attributes on two classes in ref assemblies (the rest of the changes are internal in implementation assemblies and no-op).

[dotnet-issue-labeler]

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

[dotnet-issue-labeler]

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

[dotnet-policy-service]

Tagging subscribers to this area: @dotnet/area-system-security, @bartonjs, @vcsjones
See info in area-owners.md if you want to be subscribed.

[carlossanlop]

Please send the email to Tactics requesting approval, we're running short on time for merging backports to prev7.

[ericstj]

We need to make sure the attribute for MacCatalyst comes after the iOS one due to how MacCatalyst is a superset of iOS:

That's really unusual. Should we fix the analyzer? I don't think it's normal to have attribute order matter.

This fix is fine to unblock P7 but I'm surprised to learn about this.

[lewing]

This unblocks p7 codeflow even if the actual problem is in the analyzer

[carlossanlop]

Approved by Tactics via email. Eric said offline his comment is non-blocking. Merging now.

[carlossanlop]

There was an unrelated test failure in CodePages. The tests succeeded but the test execution was marked as failed for some weird reason. Anyway, not a problem.