Use filesystem name mapping on FreeBSD #105417
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FreeBSD debug build was running into:
Turned out that 222 (aka 0xDE) is some kind of a partial magic number (e.g. https://people.redhat.com/bhubbard/cov-html-int-2019-10-09/1/574compat.cc.html uses 0xDE, while https://github.com/coreutils/coreutils/blob/83ec7a706a9f931e418ec6a084587b8995ca5388/src/stat.c#L556 is using 0x2FC12FC1 which is the same we have.
I think it's best to use name mapping rather than the alternative to use some fake name like
zfs1
whichf_fstypename
will never return on other systems.