Enhance the bound generator concept to remove duplicate parameters and make it more pervasive throughout the system #105597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d make it more pervasive throughout the system.
jkoritzinsky
added
area-System.Runtime.InteropServices
source-generator
jkoritzinsky
requested review from
AaronRobinsonMSFT,
jtschuster and
elinor-fung
3 tasks
|
It would be great to introduce some test which would assert the explicit shape of the output code, so that we feel safer doing refactorings. We had situation that the previous refactoring introduced duplicate statement in the generated code and we have not noticed for quite long time. more details |
|
I've added a test that validates the exact code output (and fixed a case of non-determinism in the JS generators in the process) |
thank you! |
This was referenced Jul 31, 2024
jtschuster
approved these changes
Aug 12, 2024
|
I'll move this and the corresponding issue to .NET 10. |
This was referenced Aug 13, 2024
3 tasks
...en/Microsoft.Interop.SourceGeneration/IncrementalGeneratorInitializationContextExtensions.cs
Show resolved
Hide resolved
AaronRobinsonMSFT
approved these changes
Aug 14, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces the number of places where we need to manually pass around a marshalling generator and its matching
TypePositionInfo.This PR also simplifies some portions of the JS generators.
Addresses #89033
Moving the generators to also store the stub code context would end up requiring us to rebind in the majority of cases, increasing GC load and not actually improving maintainability much.