Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable more flaky FSW tests for Windows #105638

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

jozkee
Copy link
Member

@jozkee jozkee commented Jul 29, 2024

Continuation of #105254.

Disabling tests more aggressively to unblock clean CI.
Tests excluded were testing functionality without using ReadDirectoryChangesW, except for some that were not using the ExpectEvent infrastructure in FileSystemWatcherTest.cs which haven't failed, I left those to see if the failures are somewhat related to test errors rather than flakyness.

@jozkee jozkee added this to the 9.0.0 milestone Jul 29, 2024
@jozkee jozkee requested review from adamsitnik and jakobbotsch July 29, 2024 18:08
@jozkee jozkee self-assigned this Jul 29, 2024
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

Copy link
Member

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @jozkee !

Copy link
Member

@jakobbotsch jakobbotsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick turnaround!

@adamsitnik
Copy link
Member

/ba-g DeadLetter is not caused by this change..

@adamsitnik adamsitnik merged commit 35b94da into dotnet:main Jul 30, 2024
80 of 84 checks passed
@jozkee jozkee deleted the disable-fsw-tests-2 branch July 30, 2024 14:37
@github-actions github-actions bot locked and limited conversation to collaborators Aug 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants