Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0-staging] Stop building AppHost in native AOT testing #105739

Conversation

ilonatommy
Copy link
Member

@ilonatommy ilonatommy commented Jul 31, 2024

Customer Impact

  • Customer reported
  • Found internally

Backport of #101270. Fixes #99423 - OOM failures in NativeAOT lanes. This is purely test infra change, so I am adding approved label directly.

Regression

  • Yes
  • No

Testing

CI.

Risk

Low, it's not a production-code change.

@MichalStrehovsky, this backport might be not enough and backporting #98939 might be needed as well. I did not include both changes at once due to your comment "We don't need to run analyzers on native AOT legs because they run on the same code elsewhere" - I have no idea if this is true for net8 as well. If you'd confirm it is save to backport, I am in favor of doing both to save the CI time.

Copy link
Contributor

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

@ilonatommy
Copy link
Member Author

It fails with #79575 because we're missing backport to sdk (dotnet/sdk#38644).

@ilonatommy ilonatommy added the blocked Issue/PR is blocked on something - see comments label Jul 31, 2024
@jkotas
Copy link
Member

jkotas commented Jul 31, 2024

Building apphost should not meaningfully contribute to the memory footprint of the build. Could you please explain why you expect that this change is going to fix the OOMs reported in #99423 ?

@ilonatommy
Copy link
Member Author

I expected that building less subsets takes less resources of the VM. Because OOM happens only on net8, I was looking for major changes to how we run the tests on net8 and net9. Dropping apphost is one, the other one is dropping analyzers (#98939). As in the description, I applied only the apphost related one, I had doubts if we can apply both.

@ilonatommy
Copy link
Member Author

Close as risky to fully backport and not guaranteed to have the expected effect.

@ilonatommy ilonatommy closed this Aug 1, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Aug 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-NativeAOT-coreclr blocked Issue/PR is blocked on something - see comments Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants