Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support [DefaultValue] when new feature switch is disabled #105766

Merged
merged 2 commits into from
Jul 31, 2024

Conversation

steveharter
Copy link
Member

Fixes #103542

Throw only on the (Type, String) ctor.

Copy link
Member

@LakshanF LakshanF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@steveharter
Copy link
Member Author

/ba-g Created new Quic issue for unrelated failure

@akoeplinger
Copy link
Member

akoeplinger commented Aug 1, 2024

This caused a test failure on dependency flow to sdk, please take a look: dotnet/sdk#42496 (comment)

I filed an issue and disabled the test temporarily: #105857

@github-actions github-actions bot locked and limited conversation to collaborators Sep 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants