-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RISC-V][LoongArch64] Pass FP struct fields at arbitrary offsets in ArgIterator and CallDescrWorker #105800
Conversation
…ding to floating-point calling convention fully
…Is are nearly the same
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shushanhf @LuckyXu-HF PTAL, I don't really know LA asm and I had no way to test it..
@MichalStrehovsky @jkotas can anyone review please? |
@dotnet/samsung @shushanhf @LuckyXu-HF Could you please review and sign-off? |
Tagging subscribers to this area: @mangod9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left review of the LA64 parts for @shushanhf and/or @LuckyXu-HF, but as for the RV64, everything looks good to me.
@tomeksowi I saw that the EmptyStructs test fails, but I'm not sure if this pr was supposed to solve this problem (?).
OK, Thanks very much. |
Co-authored-by: Qiao Pengcheng <qiaopengcheng@loongson.cn>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks
This PR no, but #106112 disables them where not supported. |
3985f11 is being scheduled for building and testingGIT: |
88815d2 is being scheduled for building and testingGIT: Release-build FAILEDbuildinfo.json |
Use new info calculated in #103945 on the VM side (shuffling thunks will be handled in a separate PR).
Stems from #101796, part of #84834, cc @dotnet/samsung @shushanhf @LuckyXu-HF