ActivatorUtilities: Do not wrap Delegate.Invoke in another delegate #105814
+6
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
added
the
community-contribution
|
Tagging subscribers to this area: @dotnet/area-extensions-dependencyinjection |
This was referenced Aug 2, 2024
|
Thanks huoyaoyuan but I'm going to mark this "No Merge" until the This doesn't meet the bar to get it into v9.0. |
steveharter
added
the
NO-MERGE
steveharter
reviewed
Aug 8, 2024
| factoryExpressionBody, provider, argumentArray); | ||
|
|
||
| Func<IServiceProvider, object?[]?, object>? result = factoryLambda.Compile(); | ||
| return result.Invoke; | ||
| ObjectFactory? result = factoryLambda.Compile(); |
There was a problem hiding this comment.
Note for other reviewers: ObjectFactory delegate is declared here:
steveharter
removed
the
NO-MERGE
steveharter
reviewed
Aug 21, 2024
| @@ -324,11 +324,11 @@ public static ObjectFactory<T> | |||
| #endif | |||
| CreateFactoryInternal(typeof(T), argumentTypes, out ParameterExpression provider, out ParameterExpression argumentArray, out Expression factoryExpressionBody); | |||
|
|
|||
| var factoryLambda = Expression.Lambda<Func<IServiceProvider, object?[]?, T>>( | |||
| var factoryLambda = Expression.Lambda<ObjectFactory<T>>( | |||
There was a problem hiding this comment.
Note for other reviewers: ObjectFactory<T> delegate is declared here
steveharter
approved these changes
Aug 21, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#104731 (comment)
There's no conversion between delegates with same signature. Using Invoke method for another type will create another level of indirection.
Here the delegates can be created directly into ObjectFactory type.