Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/9.0-preview7] [wasm][debugger] Fix debugging when JMC is enabled #105815

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Aug 1, 2024

Backport of #105756 to release/9.0-preview7

/cc @thaystg

Customer Impact

Breakpoints does not work when WASM debugging in VSCode and in VS (if new debugger is disabled).

  • Customer reported
  • Found internally

Regression

  • Yes
  • No

#103755

Testing

Manually tested.

Risk

Low risk.

Copy link
Contributor

Tagging subscribers to this area: @thaystg
See info in area-owners.md if you want to be subscribed.

@lewing lewing added the Servicing-consider Issue for next servicing release review label Aug 1, 2024
@lewing
Copy link
Member

lewing commented Aug 1, 2024

If we are taking other changes in p7 this one fixes a regression in the old debugger.

cc @mmitche @carlossanlop

@lewing lewing added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Aug 1, 2024
@jeffschwMSFT jeffschwMSFT added this to the 9.0.0 milestone Aug 1, 2024
Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. approved by tactics

@carlossanlop carlossanlop merged commit 4c12625 into release/9.0-preview7 Aug 1, 2024
21 of 26 checks passed
@carlossanlop carlossanlop deleted the backport/pr-105756-to-release/9.0-preview7 branch August 1, 2024 17:34
@github-actions github-actions bot locked and limited conversation to collaborators Sep 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Debugger-mono Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants