Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GetKeyedService overload with Type #105860

Merged
merged 2 commits into from
Aug 21, 2024
Merged

Add GetKeyedService overload with Type #105860

merged 2 commits into from
Aug 21, 2024

Conversation

martincostello
Copy link
Member

Add object? ServiceProviderKeyedServiceExtensions.GetKeyedService(IServiceProvider, Type, object?) extension method.

Resolves #102816.

@martincostello
Add GetKeyedService overload with Type
15a6a11 
Add `object? ServiceProviderKeyedServiceExtensions.GetKeyedService(IServiceProvider, Type, object?)` extension method.
Resolves dotnet#102816.
@dotnet-issue-labeler dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

1 similar comment
@dotnet-issue-labeler dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Aug 2, 2024
@build-analysis build-analysis bot mentioned this pull request Aug 2, 2024
Open
@steveharter steveharter added this to the 10.0.0 milestone Aug 9, 2024
@steveharter steveharter added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Aug 9, 2024
@steveharter
Copy link
Member

Once the main branch targets v10, this looks good. For now, I applied NoMerge attribute to this PR.

Also, the test file needs to be updated to resolve a conflict.

This was referenced Aug 12, 2024
Open
Open
Open
Open
Closed
@martincostello
Copy link
Member Author

@steveharter Is this good to go now that 9.0 has branched for rc1?

@steveharter steveharter removed the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Aug 21, 2024
@steveharter
Copy link
Member

@steveharter Is this good to go now that 9.0 has branched for rc1?

Yes main is now targeting v10.

@steveharter steveharter merged commit 631778a into dotnet:main Aug 21, 2024
84 checks passed
@martincostello martincostello deleted the gh-102816 branch August 21, 2024 20:21
@github-actions github-actions bot locked and limited conversation to collaborators Sep 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@steveharter steveharter steveharter approved these changes

Assignees
No one assigned
Labels
area-Extensions-DependencyInjection community-contribution Indicates that the PR has been added by a community member new-api-needs-documentation
Projects
None yet
Milestone
10.0.0
Development

Successfully merging this pull request may close these issues.

[API Proposal]: GetKeyedService overload that takes a System.Type
2 participants
@martincostello @steveharter