Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mono] Test llvm bump #105867

Merged
merged 3 commits into from
Aug 12, 2024
Merged

[mono] Test llvm bump #105867

merged 3 commits into from
Aug 12, 2024

Conversation

BrzVlad
Copy link
Member

@BrzVlad BrzVlad commented Aug 2, 2024

No description provided.

Copy link
Contributor

Tagging subscribers to this area: @lambdageek, @steveisok
See info in area-owners.md if you want to be subscribed.

@BrzVlad
Copy link
Member Author

BrzVlad commented Aug 2, 2024

/azp run runtime-llvm

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@BrzVlad
Copy link
Member Author

BrzVlad commented Aug 6, 2024

/azp run runtime-llvm

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@matouskozak
Copy link
Member

matouskozak commented Aug 7, 2024

The EmptyStruct crash isn't related, I missed it in the previous triage and it's a known issue #106071. The dwarf error could be related.

@BrzVlad
Copy link
Member Author

BrzVlad commented Aug 7, 2024

The dwarf error looks like some failure in gdb, so llvm x64 looks good.

@steveisok
Copy link
Member

@BrzVlad if you think the fix is good, can you take this out of draft and move it forward? I'd like to get this in before RC1 snaps.

BrzVlad added 2 commits August 9, 2024 09:27
Something seems to be wrong with llvm instruction emitting.
@BrzVlad
Copy link
Member Author

BrzVlad commented Aug 9, 2024

/azp run runtime-llvm

@BrzVlad BrzVlad marked this pull request as ready for review August 9, 2024 08:04
@BrzVlad BrzVlad requested a review from fanyang-mono as a code owner August 9, 2024 08:04
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@BrzVlad
Copy link
Member Author

BrzVlad commented Aug 11, 2024

/azp run runtime-llvm

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@BrzVlad
Copy link
Member Author

BrzVlad commented Aug 11, 2024

The llvm x64 lane is green now. This PR disables emitting of some llvm intrinsic as a current workaround, @tannergooding will take a look at this when there is some time available.

For now this looks good, a review is needed so we can merge. cc @radekdoulik

@tannergooding
Copy link
Member

This PR disables emitting of some llvm intrinsic as a current workaround, @tannergooding will take a look at this when there is some time available.

👍, can we make sure a tracking issue is logged for this?

Copy link
Member

@radekdoulik radekdoulik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please add comment with issue number to the disabled shuffle intrinsic.

@BrzVlad
Copy link
Member Author

BrzVlad commented Aug 12, 2024

Issue for follow up: #106270

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants