Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't hit all properties on Color in ColorTranslator #106042

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

JeremyKuhne
Copy link
Member

KnownColor based Color values look up the value with every method/property access. Avoid this by making Color.GetRgbValues internal and use it in ColorTranslator.

This is more of a hit in Windows where system colors also involve a system call.

Fixes #105992

KnownColor based Color values look up the value with every method/property access. Avoid this by making Color.GetRgbValues internal and use it in ColorTranslator.

This is more of a hit in Windows where system colors also involve a system call.

Fixes dotnet#105992
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ColorTranslator.ToWin32 is inefficient
2 participants