Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[System.Text.Json] Improve error handling of ref structs, including collection types with ref struct elements. #106083

Merged
merged 4 commits into from
Aug 12, 2024
Merged

[System.Text.Json] Improve error handling of ref structs, including collection types with ref struct elements. #106083

merged 4 commits into from
Aug 12, 2024

Conversation

eiriktsarpalis
Copy link
Member

Fix #98590

@eiriktsarpalis eiriktsarpalis added this to the 9.0.0 milestone Aug 7, 2024
@eiriktsarpalis eiriktsarpalis self-assigned this Aug 7, 2024
This was referenced Aug 7, 2024
Open
Open
Open
Open
Open
Open
Closed
@eiriktsarpalis
* Skip all ref like members and emit warnings.
6662f42 
* Add detection for collections with ref struct elements.
@eiriktsarpalis eiriktsarpalis changed the title STJ-SG: tolerate ref struct members with JsonIgnore. [System.Text.Json] Improve error handling of ref structs, including collection types with ref struct elements. Aug 9, 2024
@eiriktsarpalis eiriktsarpalis added the source-generator Indicates an issue with a source generator feature label Aug 9, 2024
This was referenced Aug 9, 2024
Open
Open
Closed
Open
eiriktsarpalis and others added 2 commits August 9, 2024 19:01
@eiriktsarpalis @jozkee
Update src/libraries/System.Text.Json/gen/JsonSourceGenerator.Parser.cs
58a696e 
Co-authored-by: David Cantú <dacantu@microsoft.com>
@eiriktsarpalis @jozkee
Update src/libraries/System.Text.Json/gen/JsonSourceGenerator.Parser.cs
a4542b3 
Co-authored-by: David Cantú <dacantu@microsoft.com>
This was referenced Aug 9, 2024
Open
Closed
@eiriktsarpalis eiriktsarpalis merged commit c1ab6c5 into dotnet:main Aug 12, 2024
82 of 85 checks passed
@eiriktsarpalis eiriktsarpalis deleted the fix/stj-sg-ignored-span branch August 12, 2024 08:20
@github-actions github-actions bot locked and limited conversation to collaborators Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@terrajobst terrajobst terrajobst left review comments

@jozkee jozkee jozkee approved these changes

@stephentoub stephentoub Awaiting requested review from stephentoub

@jeffhandley jeffhandley Awaiting requested review from jeffhandley jeffhandley is a code owner

Assignees

@eiriktsarpalis eiriktsarpalis

Labels
area-System.Text.Json source-generator Indicates an issue with a source generator feature
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.

System.Text.Json source generator doesn't handle ReadOnlySpan<T> properties correctly
3 participants
@eiriktsarpalis @terrajobst @jozkee