-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Sve.StoreNarrow() tests #106126
Merged
amanasifkhalid
merged 3 commits into
dotnet:main
from
SwapnilGaikwad:github-fix-sveStoreNarrow-tests
Aug 8, 2024
Merged
Fix Sve.StoreNarrow() tests #106126
amanasifkhalid
merged 3 commits into
dotnet:main
from
SwapnilGaikwad:github-fix-sveStoreNarrow-tests
Aug 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
needs-area-label
An area label is needed to ensure this gets routed to the appropriate area owners
label
Aug 8, 2024
dotnet-policy-service
bot
added
the
community-contribution
Indicates that the PR has been added by a community member
label
Aug 8, 2024
Did you verify all the modified tests are passing? |
3 tasks
Yes, @amanasifkhalid . All tests are passing. |
Stress test results
|
amanasifkhalid
approved these changes
Aug 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for fixing the naming while you were here
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
community-contribution
Indicates that the PR has been added by a community member
needs-area-label
An area label is needed to ensure this gets routed to the appropriate area owners
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the
System.IndexOutOfRangeException
for Sve.StoreNarrow() tests.The first commit fixes the template. The second commit is making all the SVE test names begin with
Sve_
.These failures slipped through potentially because we used
Sve_
pattern to run all the SVE tests.@a74nh @kunalspathak @dotnet/arm64-contrib @arch-arm64-sve @TIHan @amanasifkhalid