Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logging formatting #106283

Merged
merged 2 commits into from
Aug 13, 2024
Merged

Fix logging formatting #106283

merged 2 commits into from
Aug 13, 2024

Conversation

tarekgh
Copy link
Member

@tarekgh tarekgh commented Aug 12, 2024

Fixes #103338

@tarekgh
Copy link
Member Author

tarekgh commented Aug 12, 2024

@ericstj regarding your comment #106213 (review). I have applied your first suggestion to have the Try method initialize the value with null when returning false. I kept checking the return values of the Try methods though. Please let me know if you want to change that. Thanks!

@tarekgh tarekgh added this to the 9.0.0 milestone Aug 12, 2024
Copy link
Member

@ericstj ericstj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tarekgh tarekgh merged commit 5049a48 into dotnet:main Aug 13, 2024
84 checks passed
@tarekgh
Copy link
Member Author

tarekgh commented Aug 13, 2024

/backport to 8.0-staging

Copy link
Contributor

Started backporting to 8.0-staging: https://github.com/dotnet/runtime/actions/runs/10373759294

Copy link
Contributor

@tarekgh an error occurred while backporting to 8.0-staging, please check the run log for details!

The process '/usr/bin/git' failed with exit code 1

@github-actions github-actions bot locked and limited conversation to collaborators Sep 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Microsoft.Extensions.Logging] Bug: Logging arrays is broken and behaves unreliably
2 participants