[cdac] Change Module data descriptor for lookup maps #106291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the MethodDefToILCodeVersioningState lookup map, too. In future work (for example the SOS GetMethodDescData method) we will need to perform lookups in some of these lookup maps, so we will want the offsets of their Count and Next fields, not just a pointer to the table data. Update SOSDacImpl.GetModuleData implementation to manually add the table data offset to the values that are used by that method.
|
Tagging subscribers to this area: @tommcdon |
elinor-fung
approved these changes
Aug 12, 2024
elinor-fung
reviewed
Aug 12, 2024
Co-authored-by: Elinor Fung <elfung@microsoft.com>
This was referenced Aug 12, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the MethodDefToILCodeVersioningState lookup map, too.
In future work (for example the SOS GetMethodDescData method) we will need to perform lookups in some of these lookup maps, so we will want the offsets of their Count and Next fields, not just a pointer to the table data. Change the data descriptor to return the offsets of the LookupMap structs themselves, not their
pTablememberUpdate SOSDacImpl.GetModuleData implementation to manually add the table data offset to the lookup map addresses that are used by that method.