[LoongArch64] Modify dwarfReg in native llvm-libunwind to be consistent with the LoongArch manual. #106308
Conversation
dotnet-issue-labeler
bot
added
the
needs-area-label
dotnet-policy-service
bot
added
the
community-contribution
|
@shushanhf @MichalStrehovsky Could you review this PR? |
src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/ObjectWriter/Dwarf/DwarfExpressionBuilder.cs
Show resolved
Hide resolved
am11
added
area-NativeAOT-coreclr
and removed
needs-area-label
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas |
| UNW_LOONGARCH_F29 = 61, | ||
| UNW_LOONGARCH_F30 = 62, | ||
| UNW_LOONGARCH_F31 = 63, | ||
| UNW_LOONGARCH_F0 = 64, |
There was a problem hiding this comment.
This is vendored project from https://github.com/llvm/llvm-project/blob/main/libunwind/include/libunwind.h#L1269 . Is this a bug in the upstream project? If yes, could you please make sure that this fix is upstreamed to https://github.com/llvm/llvm-project as well?
There was a problem hiding this comment.
Thanks very much~!
You are right.
The jit/unwindloongarch64.cpp is too old.
we have to follow the latest la-abi speci https://github.com/loongson/la-abi-specs/blob/release/ladwarf.adoc
And we have to modify this file https://github.com/dotnet/runtime/blob/main/src/coreclr/jit/unwindarm64.cpp#L21
Also thanks @filipnavara
We will close this PR and push a new PR to modify the unwindarm64.cpp.
|
The new PR for modifying jit/unwindloongarch64.cpp has been submitted to #106382 |
Change the
UNW_LOONGARCHofF0-F31from 32-63 to 64-95.