Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing delegating/override method in TlsStream #106362

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

rzikm
Copy link
Member

@rzikm rzikm commented Aug 13, 2024

Fixes #99276.

Copy link
Member

@MihaZupan MihaZupan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it feasible to extend our tests to cover this case?

@rzikm
Copy link
Member Author

rzikm commented Aug 13, 2024

Is it feasible to extend our tests to cover this case?

Maybe, but I think it's not worth the investment. I would rather see TlsStream removed altogether to prevent similar bugs in the future, but that will have to wait till .NET 10.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SmtpClient SendAsync Fails to send emails even thought it doesn't error
5 participants