Fixes #106142. #106369
Merged
Fixes #106142. #106369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
dotnet-policy-service
bot
added
the
community-contribution
DeepakRajendrakumaran
force-pushed
the
106142
branch
from
9115a8a to
9d764fa
Compare
This was referenced Aug 14, 2024
|
@tannergooding @jakobbotsch , please review the code before RC1 snap. |
jakobbotsch
reviewed
Aug 14, 2024
jakobbotsch
approved these changes
Aug 14, 2024
|
Thanks for the work. If tests pass, I will merge today. |
| @@ -802,17 +802,27 @@ TBase EvaluateBinaryScalarSpecialized(genTreeOps oper, TBase arg0, TBase arg1) | |||
| case GT_ROL: | |||
| { | |||
| // Normalize the "rotate by" value | |||
| arg1 %= (sizeof(TBase) * BITS_PER_BYTE); | |||
There was a problem hiding this comment.
Was the behavioral difference for negative inputs, since %= is remainder of truncating division and so handles signed values differently?
There was a problem hiding this comment.
Yep. It was different for negative inputs. For eg. one of the test case has the rotate count show up as -2 in here.
tannergooding
approved these changes
Aug 14, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Fixes #106142
Rotate requires the count to be normalized depending on base type. This was already done with f251b17 but there was a behavioral mismatch between x86 and x64 with the mod(%) operator