Fix infinite loop in genCreateAddrMode #106732
Conversation
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
@AndyAyersMS @jakobbotsch PTAL, the previous shape used to cause an infinite loop (since it was a There is a similiar |
|
Not sure whether we should backport this to .NET 8.0 since it's likely IL Obuscation specific |
There was a problem hiding this comment.
Looks like it got introduced by #68851 (.NET 7).
I think we should go ahead and backport this.
Ah, indeed |
|
/backport to release/9.0 |
|
Started backporting to release/9.0: https://github.com/dotnet/runtime/actions/runs/10494333737 |
|
/backport to release/8.0-staging |
|
Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/10494338605 |
Fixes #106607
Not sure when exactly this regression was introduced (reproduces on net8 and net7 according to the author, however, this code has not been touched for many years). I wasn't able to create the needed shape in C# (mainly, because Roslyn does constant folding + fixes overshifts even for Debug) so I did it in raw IL.
I presume the culprit in the customer's case is IL obfuscator.