Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused custom marshaler code and move ICustomMarshaler and Color marshalling handling to managed code #106735

Merged
merged 28 commits into from
Aug 29, 2024

Conversation

jkoritzinsky
Copy link
Member

Remove complexity and layering in custom marshaler code now that SharedCustomMarshalerHelper is unused. Reuse some of the ICustomMarshaler helpers in StubHelpers for all ICustomMarshaler usage.

Move IEnumerator and System.Drawing.Color marshalling helpers into StubHelpers to remove assembly-qualified name lookup and non-corelib type lookup from the runtime.

src/coreclr/vm/callhelpers.h Show resolved Hide resolved
src/coreclr/vm/custommarshalerinfo.cpp Outdated Show resolved Hide resolved
src/coreclr/vm/mlinfo.cpp Outdated Show resolved Hide resolved
src/coreclr/vm/mlinfo.cpp Outdated Show resolved Hide resolved
src/coreclr/vm/mlinfo.cpp Outdated Show resolved Hide resolved
@jkoritzinsky jkoritzinsky merged commit 9c9f6ad into dotnet:main Aug 29, 2024
90 checks passed
@jkoritzinsky jkoritzinsky deleted the cm-cleanup branch August 29, 2024 17:45
jtschuster pushed a commit to jtschuster/runtime that referenced this pull request Sep 17, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Oct 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants