Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing .alt_entry to CoreCLR *_FakeProlog methods #106744

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Add missing .alt_entry to CoreCLR *_FakeProlog methods #106744

merged 1 commit into from
Aug 22, 2024

Conversation

filipnavara
Copy link
Member

Fixes #104105

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Aug 21, 2024
@filipnavara filipnavara mentioned this pull request Aug 21, 2024
Closed
@filipnavara
Copy link
Member Author

filipnavara commented Aug 21, 2024 •
edited
Loading

Side note: Ideally we want to unify the PATCH_LABEL/ALTERNATE_ENTRY macros between NativeAOT and CoreCLR and make this prettier. I opted to do a minimal change because this will likely need to be backported to release/9.0 branch (alongside #106442).

jkotas
jkotas approved these changes Aug 22, 2024
View reviewed changes
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jkotas jkotas merged commit 6df7807 into dotnet:main Aug 22, 2024
90 checks passed
@jkotas
Copy link
Member

jkotas commented Aug 22, 2024

this will likely need to be backported to release/9.0 branch (alongside #106442).

Could you please prepare and a PR against release/9.0 branch that has both the changes and validate it with the XCode 16? I will get it approved and merged. Thanks again!

@filipnavara filipnavara mentioned this pull request Aug 22, 2024
Merged
4 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Sep 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jkotas jkotas jkotas approved these changes

Assignees
No one assigned
Labels
area-VM-coreclr community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Xcode 16-beta compilation error: non-private labels cannot appear between .cfi_startproc / .cfi_endproc pairs
2 participants
@filipnavara @jkotas