Revert Revert "Copy published crossgen2 in artifacts/tests (#80154)" #106965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
added
the
community-contribution
|
cc @jakobbotsch second commit has the three fixes. Lets see if crossgen2-outerloop and superpmi-collect legs agree. |
|
Can you run https://github.com/dotnet/runtime/blob/main/src/coreclr/tools/Common/JitInterface/ThunkGenerator/gen.sh to update the JIT-EE GUID? Then I will run internal superpmi-collect to check. |
|
/azp run runtime-coreclr crossgen2 outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jakobbotsch
reviewed
Aug 26, 2024
|
/azp run Fuzzlyn |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Aug 26, 2024
Open
|
Fuzzlyn run looks fine (failures are actual product bugs). Outerloop run still has the #106948 #106949 failures. I don't see them on the rolling run, so they do seem related to or exposed by this PR. The "Test crossgen2-comparison build X Y" job failures still look related. Example log: https://dev.azure.com/dnceng-public/cbb18261-c48f-4abb-8651-8cdcb5474649/_apis/build/builds/788469/logs/199 superpmi-collect failed internally with the same error as before. I'm trying to get a public test version of that pipeline set up in #106960 superpmi-collect full log |
|
I was investigating it in the morning #107019. It's basically paths issue. In comparison job, the "core_root" is repurposed. It's not the same core_root we are using in other places; it's pointer to dlls/ directory instead of core_root which contains corerun/crossgen2 etc. |
am11
force-pushed
the
feature/tests/published-crossgen2
branch
from
4c7e915 to
aec8452
Compare
|
This seems like a product issue in published crossgen2.exe (https://nuget.info/packages/Microsoft.NETCore.App.Crossgen2.win-x64/9.0.0-preview.7.24405.7 tools/crossgen2.exe) which the tests are exposing: Note that it is not failing on emitting the R2R image with crossgen2, but on usage of the emitted image with r2rdump. I can switch it back to use |
|
It is unrelated issue, happening in current main as well: https://dev.azure.com/dnceng-public/public/_build/results?buildId=789431&view=results. It turned out that |
|
@jakobbotsch, @jkoritzinsky could you please rerun the crossgen2 outerloop leg. I think I have fixed the path issue in the yaml file, but there is only one way to be sure. 😅 |
|
/azp run runtime-coreclr crossgen2 outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
)" This reverts commit b579962.
am11
force-pushed
the
feature/tests/published-crossgen2
branch
2 times, most recently
from
b67985f to
2d90316
Compare
am11
force-pushed
the
feature/tests/published-crossgen2
branch
from
2d90316 to
8fff36a
Compare
It was the PowerShell thing. |
|
I hope now this is ready. Lets run the legs again to see it in action. 😎 |
These types of scenarios are one of the reasons why I prefer to use non-live AOT compilers to compile tools and achieve building with live AOT compilers by building twice like source build - first build produces live AOT compilers, and second build uses them to build the tools. |
I'll run this asap once #106960 is merged. Also there's a Helix outage right now that hopefully should be getting resolved soon... |
@jkotas, I agree that building twice would be the right approach. However, I think we can completely skip the non-live variant if this alternative hybrid approach is feasible: move the ILCompiler and crossgen2 packaging at the end of the libs subset. It will use the live MSIL variant |
|
I understand that you can make it work. We have used live builds in various forms since .NET Framework 1.0 days. Personally, I dislike using the live build as the default build experience for following reasons:
|
|
/azp run runtime-coreclr crossgen2 outerloop, runtime-coreclr superpmi-collect-test |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
Is the discussion above related to changes in this PR? Or is it purely about potential future changes? |
|
Those are not related to the Tests/Core_Root but rather publishing of nupkgs we ship. |
|
The crossgen2 superpmi-collect failures look related. E.g. https://helixre107v0xdcypoyl9e7f.blob.core.windows.net/dotnet-runtime-refs-pull-106965-merge-cceb9555ca7e45ce80/0/1/console.c6f65cfc.log?helixlogtype=result: |
|
@jakobbotsch crossgen2 publishing from all the superpmi pipelines are disabled but I forgot to revert superpmi.py change which was expecting crossgen2.exe instead of .dll. |
|
/azp run runtime-coreclr superpmi-collect-test |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Remaining failures are same as the one in main. Opened #107226. |
jakobbotsch
approved these changes
Sep 2, 2024
|
Thanks for fixing the remaining problems. |
jtschuster
pushed a commit
to jtschuster/runtime
that referenced
this pull request
Sep 17, 2024
)" (dotnet#106965) This reverts commit b579962.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #106956