[wasm] Process LinkerArg for wasm targets

[lewing]

Putting this up for discussion rather than a final form, I think it makes sense to use common names

[SingleAccretion]

CustomLinkerArg is an internal property in the NAOT targets. LinkerArg is its public counterpart.

[lewing]

CustomLinkerArg is an internal property in the NAOT targets. LinkerArg is its public counterpart.

I was working off the assumption that the use of CustomLinkerArg in wit-bindgen was correct, should that be changed to LinkerArg?

[SingleAccretion]

I was working off the assumption that the use of CustomLinkerArg in wit-bindgen was correct, should that be changed to LinkerArg?

Yes.

[lewing]

It looks like only iOS consumes LinkerArgs right now @maraf can you take a look across the platforms?

[maraf]

The CustomLinkerArg is use exclusively in NativeAOT. The LinkerArg is used in Apple, Android and LibraryMode and is added to CustomLinkerArg collection in NativeAOT https://github.com/dotnet/runtime/blob/main/src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.targets#L352

[dotnet-policy-service]

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

[lewing]

The CustomLinkerArg is use exclusively in NativeAOT. The LinkerArg is used in Apple, Android and LibraryMode and is added to CustomLinkerArg collection in NativeAOT https://github.com/dotnet/runtime/blob/main/src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.targets#L352

I just meant I missed the android use in a quick scan, thanks for the full reply. This patch just sticks it in wasi targets, it should really be in the shared bits or at least added to both.