Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm] Bump chrome for testing - linux: 128.0.6613.119, windows: 128.0.6613.120 #107504

Merged
merged 12 commits into from
Sep 19, 2024
Merged

[wasm] Bump chrome for testing - linux: 128.0.6613.119, windows: 128.0.6613.120 #107504

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
2351316
Automated bump of chrome version
github-actions[bot] Sep 8, 2024
c2d1e05
Merge branch 'main' into update-chrome-version-10755397283
ilonatommy Sep 9, 2024
a3e183f
Merge branch 'main' into update-chrome-version-10755397283
lewing Sep 10, 2024
0522828
Merge branch 'main' into update-chrome-version-10755397283
ilonatommy Sep 13, 2024
b86dbba
Addning new `BrowserArguments` is possible without changes on xharnes…
ilonatommy Sep 13, 2024
a777a4c
Add `--disable-gpu` to lib tests as well.
ilonatommy Sep 13, 2024
77d78f9
Set `PageLoadStrategy=NONE` for browser on Windows to avoid timeouts …
ilonatommy Sep 16, 2024
d8773b3
Remove whitespace.
ilonatommy Sep 16, 2024
1d48dd5
Merge branch 'main' into update-chrome-version-10755397283
ilonatommy Sep 17, 2024
ddfacc9
Set the fixing flag for lib tests on Windows.
ilonatommy Sep 18, 2024
92ec2d8
Fix: add args to chrome scenario, not node.
ilonatommy Sep 18, 2024
0e6c1df
Move appended WBT args to one place.
ilonatommy Sep 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions eng/testing/BrowserVersions.props
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
<Project>
<PropertyGroup>
<linux_ChromeVersion>126.0.6478.114</linux_ChromeVersion>
<linux_ChromeRevision>1300313</linux_ChromeRevision>
<linux_ChromeBaseSnapshotUrl>https://storage.googleapis.com/chromium-browser-snapshots/Linux_x64/1300316</linux_ChromeBaseSnapshotUrl>
<linux_V8Version>12.6.228</linux_V8Version>
<win_ChromeVersion>126.0.6478.36</win_ChromeVersion>
<win_ChromeRevision>1300313</win_ChromeRevision>
<win_ChromeBaseSnapshotUrl>https://storage.googleapis.com/chromium-browser-snapshots/Win_x64/1300320</win_ChromeBaseSnapshotUrl>
<win_V8Version>12.6.228</win_V8Version>
<linux_ChromeVersion>128.0.6613.119</linux_ChromeVersion>
<linux_ChromeRevision>1331488</linux_ChromeRevision>
<linux_ChromeBaseSnapshotUrl>https://storage.googleapis.com/chromium-browser-snapshots/Linux_x64/1331503</linux_ChromeBaseSnapshotUrl>
<linux_V8Version>12.8.374</linux_V8Version>
<win_ChromeVersion>128.0.6613.120</win_ChromeVersion>
<win_ChromeRevision>1331488</win_ChromeRevision>
<win_ChromeBaseSnapshotUrl>https://storage.googleapis.com/chromium-browser-snapshots/Win_x64/1331504</win_ChromeBaseSnapshotUrl>
<win_V8Version>12.8.374</win_V8Version>
<linux_FirefoxRevision>125.0.1</linux_FirefoxRevision>
<linux_GeckoDriverRevision>0.34.0</linux_GeckoDriverRevision>
<win_FirefoxRevision>125.0.1</win_FirefoxRevision>
Expand Down
2 changes: 1 addition & 1 deletion eng/testing/WasmRunnerTemplate.cmd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ if /I [%XHARNESS_COMMAND%] == [test] (
set "BROWSER_PATH=--browser-path^=%HELIX_CORRELATION_PAYLOAD%\chrome-win\chrome.exe"
)
if [%JS_ENGINE_ARGS%] == [] (
set "JS_ENGINE_ARGS=--browser-arg^=--js-flags^=--stack-trace-limit^=1000"
set "JS_ENGINE_ARGS=--browser-arg^=--js-flags^=--stack-trace-limit^=1000 --browser-arg^=--disable-gpu --pageLoadStrategy=none"
)
) else (
if /I [%SCENARIO%] == [WasmTestOnFirefox] (
Expand Down
2 changes: 2 additions & 0 deletions src/mono/wasm/Wasm.Build.Tests/BuildTestBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,6 +271,8 @@ protected static string RunWithXHarness(string testCommand, string testLogPath,
args.Append($" --output-directory={testLogPath}");
args.Append($" --expected-exit-code={expectedAppExitCode}");
args.Append($" {extraXHarnessArgs ?? string.Empty}");
args.Append(" --browser-arg=--disable-gpu");
args.Append(" --pageLoadStrategy=none");

// `/.dockerenv` - is to check if this is running in a codespace
if (File.Exists("/.dockerenv"))
Expand Down
Loading