[NRBF] More bug fixes#107682

Merged

adamsitnik merged 15 commits intodotnet:mainfrom adamsitnik:moreNrbfBugFixes

Sep 12, 2024

+97-136

Commits on Sep 11, 2024

be explicit, always throw InvalidOperationException for values not expected by switch statements and if/else blocks
adamsitnik
committed
be explicit, but also provide missing values
adamsitnik
committed
reject all arrays with length > Arraym.MaxLength (not just uint.MaxValue).
adamsitnik
committed
throw EOF on character count mismatch
adamsitnik
committed
remove decimal parsing optimization that was violating the NRBF spec
adamsitnik
committed
avoid int32 overflow
adamsitnik
committed
stop using Debug.Fail, remove all usages
adamsitnik
committed
StartsWithPayloadHeader should not throw on EOF
adamsitnik
committed
SerializationRecordId does not override ToString, we need to provide the value of the Id in explicit way
adamsitnik
committed
provide DebuggerDisplay for SerializationRecordId, fix it for ArrayInfo (Length property is longer present in this type)
adamsitnik
committed
throw SerializationException when PrimitiveType.String is provided in a place where it's not valid
adamsitnik
committed
revert a change that is going to get a fix in separate PR as it's not complete, but increases the amount of code that needs to be reviewed
adamsitnik
committed
fuzzer: throw SerializationException when PrimitiveType.String is provided in a place where it's not valid
adamsitnik
committed
address Loni feedback: restore the Stream position when encountering EOF
adamsitnik
committed

Commits on Sep 12, 2024

Remove "Null" and "String" from the internal enum PrimitiveType as it is always illegal to parse it and every switch needed to take this into account.
adamsitnik
committed