-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cdac] break up cdacreader into 4 separate assemblies #107709
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lambdageek
force-pushed
the
cdac-abstractions
branch
from
September 12, 2024 13:29
3ee94f8
to
a36919b
Compare
3 tasks
lambdageek
changed the title
[cdac] break up cdacreader into 3 separate assemblies
[cdac] break up cdacreader into 4 separate assemblies
Sep 12, 2024
make Registry hold a collection of contract factories, optionally with a configure callback
Closing in favor of #108156 |
This was referenced Sep 23, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area-Diagnostics-coreclr
NO-MERGE
The PR is not ready for merge yet (see discussion for detailed reasons)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Break up the monolithic cdacreader assembly into three parts:
Microsoft.Diagnostics.DataContractReader.Abstractions
just the API surface for contract implementations and clients note everything isinternal
for now (with IVT for the other assemblies) - we're not committing to a public API surface yetMicrosoft.Diagnostics.DataContractReader.Contracts
: the concrete implementations of the contracts and dataMicrosoft.Diagnostics.DataCotnractReader
: a concreteTarget
that ties everything togethercdacreader
just the unmanaged entrypoints and the legacy DAC API surfaceSOSDacImpl
To untangle things I had to add a new
IContractFactory<TProduct>
interface - this is what the target'sRegistry
uses to instantiate specific versions of contracts.Goals:
ITarget
and itsIRegistry
so that concrete contracts can be tested in isolation for example by making dummy dependent contracts that return canned answers.Registry
implementationsTarget
andContracts
without the unmanaged entrypoints or the legacy interfacesIncidentally depends on #106413, although things could probably be teased apart if we want to take this PR first