Compile the minipal as an object and static library #107889
Open
+107
−97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ross the product as a single unit instead of separate source files.
jkoritzinsky
requested review from
lambdageek,
steveisok,
marek-safar and
MichalStrehovsky
as code owners
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
am11
reviewed
Sep 17, 2024
am11
reviewed
Sep 17, 2024
am11
reviewed
Sep 17, 2024
… the full minipal building on Windows
vcsjones
reviewed
Sep 18, 2024
This was referenced Sep 19, 2024
am11
reviewed
Sep 19, 2024
This was referenced Sep 20, 2024
jkoritzinsky
requested review from
a team,
SingleAccretion,
am11 and
vcsjones
|
This PR is ready for review |
am11
approved these changes
Oct 1, 2024
There was a problem hiding this comment.
@jkoritzinsky, this is looking great! 👍
Just curious, did you see any difference in libcoreclr.so/dylib size before/after (release configuration)? I guess since we don't compile with --icf=all/safe, with objects LTO should improve the size a bit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compile the repo minipal as an object and static library for usage across the product as a single unit instead of separate source files.