Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] Enable and disable tests for hybrid globalization on Apple #108187

Merged
merged 4 commits into from
Sep 27, 2024
Merged

[iOS] Enable and disable tests for hybrid globalization on Apple #108187

merged 4 commits into from
Sep 27, 2024

Conversation

mkhamoyan
Copy link
Contributor

@mkhamoyan mkhamoyan commented Sep 24, 2024 •
edited
Loading

Remove ActiveIssue from #95338 for Compare string cases.

Contributes to #95338

@mkhamoyan mkhamoyan self-assigned this Sep 24, 2024
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Sep 24, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-globalization
See info in area-owners.md if you want to be subscribed.

@mkhamoyan
Copy link
Contributor Author

/azp run runtime-ioslike,runtime-ioslikesimulator,runtime-maccatalyst

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@mkhamoyan
Copy link
Contributor Author

/azp run runtime-ioslike,runtime-ioslikesimulator,runtime-maccatalyst

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@tarekgh tarekgh removed the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Sep 24, 2024
@tarekgh tarekgh added this to the 10.0.0 milestone Sep 24, 2024
@mkhamoyan mkhamoyan marked this pull request as ready for review September 25, 2024 08:28
ilonatommy
ilonatommy reviewed Sep 25, 2024
View reviewed changes
Copy link
Member

@ilonatommy ilonatommy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will the docs update according to this change be pushed to this PR?

@mkhamoyan
Copy link
Contributor Author

Will the docs update according to this change be pushed to this PR?

The documentation already includes information about string comparison and indexing functions and the way it is implemented can cause behavioural changes (available here). It explains that normalization is applied in certain cases, which leads to these behavioral differences. Several examples are also provided.

@mkhamoyan
Copy link
Contributor Author

/azp run runtime-ioslike,runtime-ioslikesimulator,runtime-maccatalyst

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@mkhamoyan
Copy link
Contributor Author

/azp run runtime-ioslike,runtime-ioslikesimulator,runtime-maccatalyst

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

This was referenced Sep 26, 2024
Open
Open
@mkhamoyan mkhamoyan merged commit c315bac into dotnet:main Sep 27, 2024
100 of 111 checks passed
@mkhamoyan mkhamoyan deleted the hybrid_behavior_changes branch September 27, 2024 12:13
sirntar pushed a commit to sirntar/runtime that referenced this pull request Sep 30, 2024
@mkhamoyan @sirntar
[iOS] Enable and disable tests for hybrid globalization on Apple (dot…
e6c6afe 
…net#108187)

Enable and disable tests for hybrid globalization on Apple
@github-actions github-actions bot locked and limited conversation to collaborators Oct 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@matouskozak matouskozak matouskozak left review comments

@ilonatommy ilonatommy ilonatommy approved these changes

Assignees

@mkhamoyan mkhamoyan

Labels
area-System.Globalization os-ios Apple iOS
Projects
None yet
Milestone
10.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@mkhamoyan @ilonatommy @matouskozak @tarekgh